Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing original command-line options to installer #169

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mxr576
Copy link

@mxr576 mxr576 commented Jul 12, 2018

Merge plugin did not respected --prefer-lowest option so highest-lowest testing could not be achieved with it. This PR fixes this problem and also fixes some others:

mxr576 added a commit to mxr576/apigee_devportal_composer_kickstart that referenced this pull request Jul 12, 2018
@mxr576
Copy link
Author

mxr576 commented Jul 19, 2018

Can somebody take a look at the test build in the Travis CI who has admin right? Test jobs were not even started.

Maybe @bd808?

@mxr576
Copy link
Author

mxr576 commented Aug 13, 2018

Hey,
is there anyone here who can review this PR?

@hussainweb
Copy link

Thanks for this. I found this PR when looking for a fix for --ignore-platform-reqs. I am going to pull in this as a patch and see if it works.

@ro0NL
Copy link

ro0NL commented Mar 19, 2019

ping :D forwarding --no-suggest would be 💯

@mxr576
Copy link
Author

mxr576 commented Jun 6, 2019

ping @bd808, you are the maintainer, aren't you?

@christoph-kluge
Copy link

Is this PR ongoing or dead? I'm in need of --ignore-platform-reqs.

@mxr576
Copy link
Author

mxr576 commented May 18, 2021

It is dead on my part, someone can take over. We stopped using the merge plugin because it proved to be a bottleneck several times. We rather rely on OTTB Composer features, e.g.: use path repositories on the project level to register dependencies of custom components when needed; and we developed our own upstream Composer repository for shared components. AFAIK, this covers everything that anyone used/using the merge plugin. It was a great tool back in the days but personally, I do not think it is necessary in 2021.

@christoph-kluge
Copy link

Thanks for the update. This was very helpful. After re-evaluating our use-case we also decided to drop this.

@leymannx
Copy link

leymannx commented Oct 27, 2022

@reedy you the only maintainer left? This PR needs some love. 💚

If I run composer create-project --ignore-platform-reqs on a project that requires wikimedia/composer-merge-plugin and has "merge-plugin"-"include" files configured the MergePlugin will not respect the --ignore-platform-reqs and might fail while running the built-in update command.

@leymannx
Copy link

We probably should start a new MR for it to work around the conflicts AND make it respect COMPOSER_IGNORE_PLATFORM_REQS=1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants