Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting & Addition of Github Actions #59

Closed
wants to merge 39 commits into from

Conversation

mikenye
Copy link
Contributor

@mikenye mikenye commented Jul 30, 2020

  • Linted the install.sh & uninstall.sh scripts.
  • Added Github actions to:
    • Perform linting on push/pull_request to master branch
    • Test running install.sh and uninstall.sh

I'd suggest a squash merge if you're planning to merge this, due to my many commits. :)

@mikenye
Copy link
Contributor Author

mikenye commented Jul 30, 2020

Note, commit bbe6a8c contains the change from pull request #58, which I see you have just closed and changed....

@mikenye
Copy link
Contributor Author

mikenye commented Jul 30, 2020

Fixed tar1090.sh - now matches master branch.

@wiedehopf
Copy link
Owner

how should i review this o_O

@wiedehopf
Copy link
Owner

merged manually.

@mikenye mikenye deleted the mikenye-linting-1 branch July 30, 2020 11:55
@mikenye mikenye restored the mikenye-linting-1 branch November 19, 2020 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants