-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor UI improvements in HTML layout, alignment, security fixes as per Chrome's Lighthouse recommendations #53
Conversation
Merge latest
…ssages/History/Jump to airport
…ncing latest versions
<meta charset="utf-8"/> | ||
<head> | ||
<meta charset="utf-8" /> | ||
<meta name="description" content="Improved dump1090-fa web interface"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a good description, just my opinion.
How about: Tar1090 - Live flight tracking map brought to you by ADS-B Exchange and our worldwide network of feeders
? Or something a little more SEO-ey? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it sounds much better but just copied it from this repo readme. I think it is up to wiedehopf to change it.
What is the package json and lock json required for? |
Javascript project manifest (that this project basically is). Not required if you don't want to use it but convenient way to specify all external dependencies, automatically pull them with npm-check-updates and etc. https://nodejs.org/en/knowledge/getting-started/npm/what-is-the-file-package-json/ |
I despise npm with a passion. I also don't have use for the gitignore file but i might add that anyhow because it doesn't hurt and doesn't need updating. I'm not sure how bugs for example in jquery could be security relevant? Thank you for the close button and taking a look. If you want to help with some more html, you could continue this: 637042e I should probably document this, but to test html changes on your local ADS-B receiver, you can run |
But it does not hurt to have it if you change your mind at some point.
It is useful for somebody like me who uses Visual Studio for development and not just notepad. :)
In general my philosophy is to always run on latest third-party packages and pay attention to what security tools tell me even if security problem (no matter how remote) unlikely and/or I don't understand it's impact.
w/e - what it means? Invalid HTML in this case was missing inside . One or two cases.
I'll check.
That's nice to know even it is not applicable for me as I do development on Windows. Is there a way to point local Windows copy to existing receiver on Raspberry? |
Do you have more information on what problem is? Screenshot maybe? And what you are trying to accomplish? |
So the aircraft details are just divs below each other. I fixed that by making the top box a table, making a row from every div. w/e means whatever In regards to pointing your local windows copy to json files .... And don't call vim notepad please ;) |
I've cherry picked a couple of commits / changed some stuff. I'll count this as somewhat applied and close the PR. The rowspacer change ... makes the html more ugly to read and it wasn't done for all instances. |
No description provided.