Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI quality of life improvements #295

Closed
wants to merge 2 commits into from
Closed

UI quality of life improvements #295

wants to merge 2 commits into from

Conversation

wendikristine
Copy link

  • new icons
  • standardized buttons
  • minimal margins/padding to improve accessibility
  • minor code cleanup (such as removing extra spaces)

…prove accessibility, minor code cleanup (such as removing extra spaces).
@wiedehopf
Copy link
Owner

Not a fan of the color changes.

The icons are nice i suppose.

@wendikristine
Copy link
Author

I changed it back to the slightly lighter teal.

@wiedehopf
Copy link
Owner

Hmm i should have been more specific.

The sliders in the settings have bad contrast. (not sure how the slider background became teal, slider should remain light blue as well)
The checkboxes in the settings have bad contrast. (the light blue worked fine and doesn't need changing)

That's the problematic color changes i'm talking about.

I'm still not 100% sure about the changed buttons i'll have to ask some users their opinion.
Possibly i just need to go through the indivdual changes and possibly only take some of them.

@Hank076
Copy link

Hank076 commented Mar 15, 2024

Propose some suggestions for icon

  • The icon above Total Aircraft is good, but it's a bit offset in position
  • The Legend's icon is great, but its height is different from the icon next to it
  • Unable to understand the function of this button through the icon on the expand sidebar
  • The cursor of the Zoom in & Zoom out buttons is also a bit out of place. I hope the cursor can be maintained as it is

2024-03-15_172922
Chrome v122.0.6261.128

@wendikristine
Copy link
Author

wendikristine commented Mar 15, 2024

Thank you both for the suggestions. Since I'm not a feeder it was challenging to get the icons previewed. I just ordered the equipment to be a feeder and I'll take another stab at it when it arrives.

@wendikristine wendikristine marked this pull request as draft March 18, 2024 14:52
@wendikristine
Copy link
Author

My work is too sloppy. I'll nuke this and do it properly.

@wendikristine
Copy link
Author

@Hank076 How did you apply my changes to your local feeder map? The best I can figure out is to open my feeder map in Firefox and import a style sheet. I can't load or otherwise link/reference an updated .html or any local images.

@wiedehopf
Copy link
Owner

./install.sh test
Will install from your local git directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants