Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using flag-icons library #280

Merged
merged 4 commits into from
May 19, 2024
Merged

Using flag-icons library #280

merged 4 commits into from
May 19, 2024

Conversation

makrsmark
Copy link
Contributor

the original flags come from a website that is not maintained.

fixes #263

the original flags come from a website that is not maintained.
using svg instead of png

new flags are pulled from
https://github.com/lipis/flag-icons
renamed min.js to include the version
updating script to use background img
@wiedehopf wiedehopf changed the base branch from master to flags May 19, 2024 13:42
@wiedehopf wiedehopf merged commit 8a0d69a into wiedehopf:flags May 19, 2024
@wiedehopf
Copy link
Owner

So ... i've finally looked at this.
I've massaged it to where i like it except for one somewhat important detail.
Aspect ratio of the flags.
4x3 just doesn't look as nice as the 5x3 the previous flags are using.
3x2 would also be fine, but 4x3 is just too square.

Thus i might just keep it in the flags branch and not pursue further, sorry!
Might just be easier to deal with the individual flag pngs and update those, we will see.
Possibly i'll use it at some point.

@makrsmark
Copy link
Contributor Author

@wiedehopf would it be worth looking at https://www.npmjs.com/package/country-flag-icons instead?

@wiedehopf
Copy link
Owner

wiedehopf commented May 19, 2024

It is indeed, i can fiddle around myself thank you.

https://gitlab.com/catamphetamine/country-flag-icons/-/blob/master/flags/3x2/flags.css?ref_type=heads

This doesn't seem to be updated otherwise i'd very much like a single file solution.

But the 3x2 folder would seem easily adoptable.

@wiedehopf
Copy link
Owner

There seem to be 2 3x2 folders, so it's a bit confusing which is the updated one?

Seems they are both updated and the build propagates from one to the other.

@wiedehopf
Copy link
Owner

ee4b382

squashed it all down to 1 commit as i don't like to keep any extra data / files in the git history.
added myself as co-author.

The flags folder has a README.md that links back to the repo the flags are taken from.
Also added the MIT license in there.

Does that seem fine like that to you?
Thank you for adding all the country codes to icao.js btw, just noticed that that was necessary :)

@makrsmark
Copy link
Contributor Author

works for me!

@makrsmark makrsmark deleted the flags branch May 19, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vietnam Flag's color is not the correct Red
2 participants