Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some variables that I didn't see declaration scope #27

Closed
wants to merge 1 commit into from
Closed

some variables that I didn't see declaration scope #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
some variables that I didn't see declaration scope 
added comments near vars I didn't see declared - which makes them global and no GC is done
239
244
I could be wrong
  • Loading branch information
@adsb-related-code
adsb-related-code committed Mar 16, 2020
commit aa178fa3b46105fca263a45d151595e6c69582cd
3 changes: 3 additions & 0 deletions html/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,12 @@ function processReceiverUpdate(data, init) {
var uat = false;
if (data.uat_978 == "true") {
uat = true;
// Are uat_now and uat_last intended to be undeclared globals?
uat_last = uat_now;
uat_now = data.now;
} else {
if (data.now > now || globeIndex) {
// same with last and now ..
last = now;
now = data.now;
}
Expand Down Expand Up @@ -387,6 +389,7 @@ function fetchData() {
dataType: 'json' });

FetchPendingUAT.done(function(data) {
// undeclared so global and no GC
uat_data = data;
FetchPendingUAT = null;
});
Expand Down