improve CORS security #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest not merging this until @kx1t agrees that this is what he's looking for. |
This has nothing to do with CORS. There is no need for this header. This should address a change requested by Ramon (@kx1t) Signed-off-by: Dirk Hohndel <[email protected]>
|
The branch name is now completely bogus, but this should still address the concern that @kx1t voiced to me. |
|
(also this has no impact to security as the client is not the authority on CORS, the server is, so the request header did/does/will always do nothing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a wildcard access control allow origin, limit it to the route api server.
Change requested by Ramon (@kx1t)