Route burst limit #243
Merged
Route burst limit #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Never send more than 100 callsigns to the route server. If there are more queued up (for example on an aggregator when the user zooms out), they are sent in batches of 100 callsigns every 10 seconds. Signed-off-by: Dirk Hohndel <[email protected]>
With the limit of 100 callsigns per API call, sending these requests every second should create a more responsive experience while still not overloading the server. Signed-off-by: Dirk Hohndel <[email protected]>
Again, aiming for a more responsive look and feel. Signed-off-by: Dirk Hohndel <[email protected]>
iakat
approved these changes
May 9, 2023
|
Pinging @wiedehopf ... any chance this could get merged. Completely invisible to anyone not enabling the routes. |
|
It's three really tiny, painfully simple and obvious changes. With detailed commit messages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with this for a couple of weeks we noticed two issues:
This patch series limits each individual route API call to a maximum of 100 callsigns and in return allows those calls once every second. This reduces the burst load on the route API server and improves the user experience.
The code has been tested on a production server :)
Thanks to Katia for the idea and the testing.