Bugfix - add trailing slash to install script, enabling jq
to be installed where it is not already present
#242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
I noted recently that a fresh install to a rasperry pi / raspbian OS did not install
jq
.jq
installed, several scripts which parse/modify json files fail to be created/updated, andtar1090
functionality which rely on these json files fails to load/run correctly (e.g.,pTracks
)jq
being unavailable, can be observed viajournalctl
jq
resolved the errorsjq
not being installed as part of the normal install process appears to be due to an omitted trailing slash when specifying the string to pass intoread
(the trailing token is required to denote the end of the last item).This pull request inserts that trailing slash.
For reference/convenience, these are the relevant lines within
install.sh
.Test script
To test/validate this, here is a slightly tweaked copy of the script which allows for toggling between the slash being present or not and the each branch of the
if
to be printed to the console.Terminal output
Note that without the trailing slash,
jq
is neither required nor found to be absent (meaning that it failed to be read).