Speed is not displayed (dump1090-mutability) #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I run tar1090 with dump1090-mutability and I have to apply this patch to show the speed in the airplane labels and the table on the right. This is related to the fix you've done for #111, but in my opinion this fix was incomplete.
|
should be fixed. this PR wasn't the right thing to do. |
|
Also really, don't use dump1090-mutability. |
I don't understand. It is definitely not fixed without my patch. And why is a PR not the right thing to provide patches? What would be the right thing? |
|
I pushed a commit which is linked. Cleaned up the entire logic instead of making the change you proposed. |
|
Feel free to let me know if my commit didn't fix the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run tar1090 with dump1090-mutability and I have to apply this patch to show the speed in the airplane labels and the table on the right. This is related to the fix you've done for #111, but in my opinion this fix was incomplete.