Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix api url for planetspotters.net #188

Closed
wants to merge 1 commit into from

Conversation

zivillian
Copy link

@zivillian zivillian commented Jun 20, 2022

this fixes the planespotters.net images for planes which have no icao code in their database but have images like the german military NH90 with registration 79+23

@wiedehopf
Copy link
Owner

too many wrong pictures, that's why the code exists in the first place.

@zivillian
Copy link
Author

Do you have an example, where this returns a wrong image? Maybe I can come up with a better solution.

@wiedehopf
Copy link
Owner

This is the request it makes: https://api.planespotters.net/pub/photos//hex/3F9E5B?reg=79+23&icaoType=NH90

It's what we agreed on with planespotters.
It should be ok to only match the registration and still return something, feel free to contact planespotters about this.

@zivillian zivillian closed this Jun 20, 2022
@zivillian zivillian deleted the planespotter branch June 20, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants