UI/UE: Make current toggle button state more obvious.

[xax]

Using tar1090 as the public ADSBx frontend for quite some time, I still would not learn to intuitively determine the current state of the various toggle buttons (i.e. ”LOKMPIRF“). Bright white signaling an off state while a black button is active might confuse other users, too, I assume. (The current approach isn't a convincing ”dark cockpit“ comparison, eiher.)

before	after

Of course you can always resort to a user style on desktop instead of improving upstream:

@-moz-document domain("globe.adsbexchange.com") {
.button.activeButton {
    color: #9D9;
}

.button.inActiveButton {
    color: #D99;
}

}

[wiedehopf]

Great choice for red green blind people.
Not that i design specifically with that in mind ... but your proposal seems .. well.

Anyhow it's fine as it is.

[xax]

Oh, you are one of those maintainers. Thanks a lot appreciating suggestions.

By the way: Right now everybody has to guess button state; with colors changed as proposed – not, that they could be chosen differently but nonetheless more intuitively… duh! – that would reduce to those being r/g colorblind. Let's all suffer lest we discriminate™.

[wiedehopf]

Black is on, white is off.
Doesn't seem like guessing to me.
Maybe you guess once, see the effect it has and you can deduce that black means on.

UI decisions are just that, decisions.
Now you're insinuating i just ignore input / PRs but that's not the case.
But i do have the choice what do with input / PRs.

I could imagine a slight border for active options, maybe a pixel wide.
Not sure how it would look though, no matter what you might think, i like how the interface looks.
But i'd certainly consider such a border to mark activeButton better.
It's not gonna be greed red color coding.

If you will, just ignore that is said that it's fine as it is ....
I consider it fine but i get that there are differing opinions :)
So that remark was unproductive.