Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to persist filters to local storage. #152

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

lart2150
Copy link
Contributor

This will add a setting (disabled by default) to persist the filters to local storage.

This should resolve #14

I tested with all tracks enabled and then enabled a filter and it cleared all non selected plans that don't match.

@wiedehopf
Copy link
Owner

So this needs big fat warnings on load that the old filters have been restored or this produces tons of bug reports.
Yes even if the setting is disabled by default.

Honestly having the filters encoded in the URL might be less of a support issue and more useful as people can bookmark various filter combinations.

Could you make a warning with two buttons "Disable Filters" and "Hide this" or along those lines that shows in the main map area?

On a whole other topic:
It would be great to have the html for the aircraft details on the left generated somehow.
Or something along those lines so it's easy to have a secondary two row (current single row) display of the aircraft details that could fill the lower area of a smartphone.
Presenting the picture and some info side by side.
Just if you're looking for something to work on.

@lart2150
Copy link
Contributor Author

What if the checkbox is "include filters in share link". I would then likely break out each filter into separate parameter.

@wiedehopf
Copy link
Owner

Yeah that would certainly work well!

@lart2150
Copy link
Contributor Author

I updated the PR to add the filters as get params and changed the setting to add the params to the share link but not the address bar.

@wiedehopf wiedehopf merged commit fb7cc43 into wiedehopf:master Oct 2, 2021
@sxdjt
Copy link

sxdjt commented Oct 3, 2021

Nice!! Thank you.

@lart2150 lart2150 deleted the persistent-filters branch October 5, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persistent filters (Feature Request)
3 participants