Add table_type option for :set and :ordered_set #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine, although I would prefer if the option were simply If you'd like to update that, then I'm happy to merge - or I'm happy to merge and make the changes after. Up to you, Thank you! |
|
That makes sense to me - I think bag / duplicate_bag change the semantics of the storage enough that they don't make a ton of sense as options, so the boolean flag seems good! I have updated this PR accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #328.
I didn't put too much thought into any of the documentation, so feel free to make any changes you would like to see! Thanks again for all your work on this.
Chris