Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quoted keyword warnings on Elixir 1.7 #191

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Fix quoted keyword warnings on Elixir 1.7 #191

merged 1 commit into from
Jul 13, 2018

Conversation

ivan
Copy link
Contributor

@ivan ivan commented Jul 13, 2018

This fixes:

warning: found quoted keyword "docs" but the quotes are not required. Note that keywords are always atoms, even when quoted, and quotes should only be used to introduced keywords with foreign characters in them
  [...]/deps/cachex/mix.exs:58

warning: found quoted keyword "bench" but the quotes are not required. Note that keywords are always atoms, even when quoted, and quotes should only be used to introduced keywords with foreign characters in them
  [...]/deps/cachex/mix.exs:59

warning: found quoted keyword "cachex" but the quotes are not required. Note that keywords are always atoms, even when quoted, and quotes should only be used to introduced keywords with foreign characters in them
  [...]/deps/cachex/mix.exs:60

warning: found quoted keyword "coveralls" but the quotes are not required. Note that keywords are always atoms, even when quoted, and quotes should only be used to introduced keywords with foreign characters in them
  [...]/deps/cachex/mix.exs:61

warning: found quoted keyword "bench" but the quotes are not required. Note that keywords are always atoms, even when quoted, and quotes should only be used to introduced keywords with foreign characters in them
  [...]/deps/cachex/mix.exs:66

The warning was introduced in elixir-lang/elixir#7838

@whitfin
Copy link
Owner

whitfin commented Jul 13, 2018

It's so gross that Elixir warns you on this, consistency is so much better.

@ivan thanks for the contribution!

@whitfin whitfin merged commit e719293 into whitfin:master Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants