Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember to import Cachex.Spec when using limit record #159

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

comboy
Copy link
Contributor

@comboy comboy commented Jan 16, 2018

Hi, great lib. Took me a moment to realize where is that limit() coming from so I wanted to save that moment for other people.

I also needed to use github version in my mix.env, I'm assuming it's just that the mix version is out of date? Would be nice to bump a version and push since most people will use doc pages linked in README.

Keep up the great work.

@whitfin whitfin changed the title remember to import Cachex.Spec when using limit record Remember to import Cachex.Spec when using limit record Jan 16, 2018
@whitfin
Copy link
Owner

whitfin commented Jan 16, 2018

Hi @comboy!

Thank you for the PR. I'm intending on adding a whole section about Cachex.Spec and linking it in the appropriate places, but this looks good for the meantime.

You need to use the GitHub version to get the latest, yes. I'm working on a v3 that's currently out in master and is incomplete (see the v3 milestone for what's left). As a general rule people should only use the docs out on Hex.pm as they're set against a current version.

If you're just looking to gain access to limits, they're available in the version on Hex.pm - please see here. Is there some reason you're forced to use master?

Thanks for the PR!

@whitfin whitfin merged commit ce68db5 into whitfin:master Jan 16, 2018
@comboy
Copy link
Contributor Author

comboy commented Jan 16, 2018

You're fast. Thanks. I don't think I need anything from current master, I just wasn't aware that there was this %Cache.Limit struct before, because I used links from the readme which are for the master version (maybe use current hex version branch as default view for github?). Indeed I should have checked hex docs instead.

It's great that you keep the roadmap and your detailed thoughts regarding development on github issues. Really very well maintained project. Congrats and thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants