Add support for Serverless Framework's variables. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@I-himawari hey, sorry for VERY late reply! Thank you for pointing out this problem. I fixed that in #33 and will be looking at the env thing you mentioned about in this PR later today/tomorrow. |
whisller
added a commit
that referenced
this pull request
Dec 15, 2020
@I-himawari in #29 mentioned idea of using `sls print` instead of manually parsing variables. This PR introduces this functionality.
whisller
added a commit
that referenced
this pull request
Dec 15, 2020
@I-himawari in #29 mentioned idea of using `sls print` instead of manually parsing variables. This PR introduces this functionality.
whisller
added a commit
that referenced
this pull request
Dec 15, 2020
@I-himawari suggested improvement in #29 which sets env variables defined in `serverless.yml` file. This PR introduces this functionality.
|
@I-himawari I will close this issue as improvements you've mentioned are in place. I will be releasing new version shortly. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using using sls print command instead of current yaml parser.