Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransformStream cleanup using "Transformer.cancel" #1283

Merged
merged 15 commits into from
Sep 30, 2023
Merged

TransformStream cleanup using "Transformer.cancel" #1283

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6ec5260
TransformStream cleanup using "Transformer.cancel"
lucacasonato Jun 8, 2023
1c65d61
remove `controller` argument
lucacasonato Jun 10, 2023
33fada8
fixes
lucacasonato Jun 12, 2023
2e503c6
fix
lucacasonato Jun 12, 2023
5b00d08
Version 2: run cancel before cancelling
lucacasonato Jun 12, 2023
9fa485f
Address grammar comment
lucacasonato Jun 18, 2023
f22727f
ci
lucacasonato Jun 29, 2023
4b33032
review comments
lucacasonato Jul 17, 2023
161e3fa
review comments
lucacasonato Jul 17, 2023
40eadec
Fix controller.error() race
lucacasonato Jul 17, 2023
9c8ad53
Lint
lucacasonato Jul 17, 2023
5267f70
Fix trailing whitespace
MattiasBuelens Jul 17, 2023
7631e52
typo
lucacasonato Sep 15, 2023
16900ad
editorial fixes
lucacasonato Sep 29, 2023
4d2abe5
update wpt submodule
lucacasonato Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
editorial fixes
  • Loading branch information
@lucacasonato
lucacasonato committed Sep 29, 2023
commit 16900ad719f1888d6c239549a30f81c845f2acef
27 changes: 13 additions & 14 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5749,7 +5749,7 @@ the following table:
<tbody>
<tr>
<td><dfn>\[[cancelAlgorithm]]</dfn>
<td class="non-normative">A promise-returning algorithm, taking one argument (the [=reason=] for
<td class="non-normative">A promise-returning algorithm, taking one argument (the reason for
cancellation), which communicates a requested cancellation to the [=transformer=]
<tr>
<td><dfn>\[[finishPromise]]</dfn>
Expand Down Expand Up @@ -6121,18 +6121,6 @@ side=] of [=transform streams=].
The following abstract operation is used to implement the [=underlying source=] for the [=readable
side=] of [=transform streams=].

<div algorithm>
<dfn abstract-op lt="TransformStreamDefaultSourcePullAlgorithm"
id="transform-stream-default-source-pull">TransformStreamDefaultSourcePullAlgorithm(|stream|)</dfn>
performs the following steps:

1. Assert: |stream|.[=TransformStream/[[backpressure]]=] is true.
1. Assert: |stream|.[=TransformStream/[[backpressureChangePromise]]=] is not undefined.
1. Perform ! [$TransformStreamSetBackpressure$](|stream|, false).
1. Return |stream|.[=TransformStream/[[backpressureChangePromise]]=].
</div>


<div algorithm>
<dfn abstract-op lt="TransformStreamDefaultSourceCancelAlgorithm"
id="transform-stream-default-source-cancel">TransformStreamDefaultSourceCancelAlgorithm(|stream|,
Expand Down Expand Up @@ -6162,6 +6150,17 @@ side=] of [=transform streams=].
1. Return |controller|.[=TransformStreamDefaultController/[[finishPromise]]=].
</div>

<div algorithm>
<dfn abstract-op lt="TransformStreamDefaultSourcePullAlgorithm"
id="transform-stream-default-source-pull">TransformStreamDefaultSourcePullAlgorithm(|stream|)</dfn>
performs the following steps:

1. Assert: |stream|.[=TransformStream/[[backpressure]]=] is true.
1. Assert: |stream|.[=TransformStream/[[backpressureChangePromise]]=] is not undefined.
1. Perform ! [$TransformStreamSetBackpressure$](|stream|, false).
1. Return |stream|.[=TransformStream/[[backpressureChangePromise]]=].
</div>

<h2 id="qs">Queuing strategies</h2>

<h3 id="qs-api">The queuing strategy API</h3>
Expand Down Expand Up @@ -7209,7 +7208,7 @@ reason.
for="TransformStream/set up"><var>transformAlgorithm</var></dfn>, an optional algorithm <dfn
export for="TransformStream/set up"><var>flushAlgorithm</var></dfn>, and an optional algorithm <dfn
export for="TransformStream/set up"><var>cancelAlgorithm</var></dfn>, perform the following steps.
|transformAlgorithm|, if given, |flushAlgorithm| and |cancelAlgorithm|, may return a promise.
|transformAlgorithm| and, if given, |flushAlgorithm| and |cancelAlgorithm|, may return a promise.

1. Let |writableHighWaterMark| be 1.
1. Let |writableSizeAlgorithm| be an algorithm that returns 1.
Expand Down
Loading