-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make input/textarea.selection{Direction,Start,End} not throw #1006
Conversation
Return null instead of throwing InvalidStateError for input.selectionDirection, selectionStart, and selectionEnd, when they do not apply. Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=28225.
Sounds like a good change if it doesn't break websites assumptions (ie. have a catch, thus assume non-null). |
I tried looking for things that could regress but didn't find anything:
|
Seems ok to me; please update web platform tests as needed to make sure implementors get this on their radar or something.. |
ok to me |
Tests at web-platform-tests/wpt#2825 |
…owing (#2825) This tests whatwg/html#1006.
This keeps up with a recent spec change: whatwg/html#1006.
…Start,End} not throwing (web-platform-tests#2825) This tests whatwg/html#1006.
Bugs: |
…Start,End} not throwing (web-platform-tests#2825) This tests whatwg/html#1006.
This keeps up with a recent spec change: whatwg/html#1006.
Return null instead of throwing
InvalidStateError
forinput.selectionDirection
,selectionStart
, andselectionEnd
, whenthey do not apply.
Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=28225.