Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"parse a header value" should be more careful with types #474

Closed
annevk opened this issue Jan 31, 2017 · 0 comments
Closed

"parse a header value" should be more careful with types #474

annevk opened this issue Jan 31, 2017 · 0 comments

Comments

@annevk
Copy link
Member

annevk commented Jan 31, 2017

It's passed either a header or header list. Seems we could make the algorithm deal with that a little better than just ignore the differences.
@annevk annevk mentioned this issue Feb 22, 2017
Closed
annevk added a commit that referenced this issue Feb 22, 2017
@annevk
Breaking: redo value parsing as value extraction
a9d8f59 
We now have two separate algorithms that can be used rather than one
with type confusion:

* “extracting header values” (takes a header)
* “extracting header list values” (takes a name and a header list)

Fixes #474.
@annevk annevk mentioned this issue Feb 22, 2017
Merged
annevk added a commit that referenced this issue Feb 22, 2017
@annevk
Breaking: redo value parsing as value extraction
68a9867 
We now have two separate algorithms that can be used rather than one
with type confusion:

* “extracting header values” (takes a header)
* “extracting header list values” (takes a name and a header list)

Fixes #474.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@annevk