Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bikeshed link errors for implementation-defined and url #1580

Closed
1 of 2 tasks
dlrobertson opened this issue Dec 27, 2022 · 2 comments
Closed
1 of 2 tasks

Fix bikeshed link errors for implementation-defined and url #1580

dlrobertson opened this issue Dec 27, 2022 · 2 comments

Comments

@dlrobertson
Copy link
Member

dlrobertson commented Dec 27, 2022

Summary

There appear to be some link errors that bikeshed throws some warnings for the following, due to multiple definitions:

Example

 make local
bikeshed spec fetch.bs fetch.html --md-Text-Macro="COMMIT-SHA LOCAL COPY"
LINK ERROR: Multiple possible 'url' dfn refs for '['/']'.
Arbitrarily chose https://url.spec.whatwg.org/#concept-url
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:url; type:dfn; text:url
spec:webdriver-bidi; type:dfn; text:url
<a data-link-for="/" data-link-type="dfn" data-lt="URL">URL</a>
LINK ERROR: Multiple possible 'implementation-defined' dfn refs.
Arbitrarily chose https://infra.spec.whatwg.org/#implementation-defined
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:infra; type:dfn; text:implementation-defined
spec:ecmascript; type:dfn; text:implementation-defined
<a data-link-type="dfn" data-lt="implementation-defined">implementation-defined</a>
LINK ERROR: Multiple possible 'urls' dfn refs for '['/']'.
Arbitrarily chose https://url.spec.whatwg.org/#concept-url
To auto-select one of the following refs, insert one of these lines into a <pre class=link-defaults> block:
spec:url; type:dfn; text:url
spec:webdriver-bidi; type:dfn; text:url
<a data-link-for="/" data-link-type="dfn" data-lt="URLs">URLs</a>
 ✔  Successfully generated, with 3 linking errors
dlrobertson added a commit to dlrobertson/fetch that referenced this issue Dec 28, 2022
dlrobertson added a commit to dlrobertson/fetch that referenced this issue Dec 28, 2022
Add a link-defaults block to specify defaults for ambiguous url and
implementation-defined links.

Fixes: whatwg#1580
@whimboo
Copy link

whimboo commented Jan 2, 2023

The underlying issue with the WebDriver BiDi spec should be fixed now (w3c/webdriver-bidi#347)

dlrobertson added a commit to dlrobertson/fetch that referenced this issue Jan 2, 2023
Add a link-defaults block to specify defaults for ambiguous
implementation-defined links.

Fixes: whatwg#1580
@dlrobertson
Copy link
Member Author

The underlying issue with the WebDriver BiDi spec should be fixed now (w3c/webdriver-bidi#347)

Thanks!

dlrobertson added a commit to dlrobertson/fetch that referenced this issue Jan 2, 2023
Add a link-defaults block to specify defaults for ambiguous
implementation-defined links.

Fixes: whatwg#1580
@annevk annevk changed the title Fix bikeshed link errors for implementation-definedd and url Fix bikeshed link errors for implementation-defined and url Jan 3, 2023
@annevk annevk closed this as completed in 98b3a58 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants