-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop "keyevents" as an alias of "keyboardevent" for createEvent #148
Comments
TextEvent already behaves similar too. Gecko supports TextEvents; but nobody else does. Of course TextEvent isn't part of the current spec and is deprecated; but nonetheless there are other examples of things Gecko supports that Safari, Edge, and Blink based browsers don't support. |
Paging @smaug---- for thoughts. |
TextEvent isn't in https://w3c-test.org/dom/nodes/Document-createEvent.html, fortunately. Blink/WebKit are also very naughty, by supporting all known event interface names for |
Gecko used to have only keyevents, and keyboardevent was added in |
How about removing it from the spec and adding it back only if there's evidence that it's needed for web compat, e.g. if Gecko fails to remove it? Leaving it in risks that someone implements it, if a reviewer doesn't pay close attention. |
That sounds reasonable to me. @smaug---- is there a bug against Gecko on removing this? |
It has been dropped from DOM: whatwg/dom#148
I open bug for Gecko: |
It has been dropped from DOM: whatwg/dom#148
There's a test for this in wpt and a proposed fix in Blink:
https://w3c-test.org/dom/nodes/Document-createEvent.html
https://codereview.chromium.org/1569813002/
As discussed in that review, it looks like this alias is only supported by Gecko, and so we think it would be better to drop it from the spec. If it turns out to be unsafe to remove in Gecko, then the only way out is for all other engines to add it.
The text was updated successfully, but these errors were encountered: