Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "keyevents" as an alias of "keyboardevent" for createEvent #148

Closed
foolip opened this issue Jan 12, 2016 · 7 comments
Closed

Drop "keyevents" as an alias of "keyboardevent" for createEvent #148

foolip opened this issue Jan 12, 2016 · 7 comments

Comments

@foolip
Copy link
Member

foolip commented Jan 12, 2016

There's a test for this in wpt and a proposed fix in Blink:
https://w3c-test.org/dom/nodes/Document-createEvent.html
https://codereview.chromium.org/1569813002/

As discussed in that review, it looks like this alias is only supported by Gecko, and so we think it would be better to drop it from the spec. If it turns out to be unsafe to remove in Gecko, then the only way out is for all other engines to add it.

@dtapuska
Copy link

TextEvent already behaves similar too. Gecko supports TextEvents; but nobody else does. Of course TextEvent isn't part of the current spec and is deprecated; but nonetheless there are other examples of things Gecko supports that Safari, Edge, and Blink based browsers don't support.

@annevk
Copy link
Member

annevk commented Jan 12, 2016

Paging @smaug---- for thoughts.

@foolip
Copy link
Member Author

foolip commented Jan 12, 2016

TextEvent isn't in https://w3c-test.org/dom/nodes/Document-createEvent.html, fortunately.

Blink/WebKit are also very naughty, by supporting all known event interface names for createEvent, not just the ones listed in the spec.

@smaug----
Copy link
Collaborator

Gecko used to have only keyevents, and keyboardevent was added in
https://bugzilla.mozilla.org/show_bug.cgi?id=238773, so, long ago.
In mozilla-central there are several tests using "keyevents", so I guess would need to fix those and then add some telemetry and based on that say something here.

@foolip
Copy link
Member Author

foolip commented Feb 13, 2016

How about removing it from the spec and adding it back only if there's evidence that it's needed for web compat, e.g. if Gecko fails to remove it? Leaving it in risks that someone implements it, if a reviewer doesn't pay close attention.

@annevk
Copy link
Member

annevk commented Feb 13, 2016

That sounds reasonable to me. @smaug---- is there a bug against Gecko on removing this?

@ArkadiuszMichalski
Copy link
Contributor

I open bug for Gecko:
https://bugzilla.mozilla.org/show_bug.cgi?id=1261874

ivanzr pushed a commit to ivanzr/web-platform-tests that referenced this issue Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants