Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup ingredient details in typeahead suggestions and recently used #613

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Dieterbe
Copy link
Contributor

unfortunately, we only get the image when getting suggestions. not when using the ingredients API or when browsing recently used ingredients. this would be a nice thing to add to the backend @rolandgeider :) i also think a link to the "upstream source" could be nice. (e.g. to OFF or USDA if applicable)

@Dieterbe Dieterbe marked this pull request as draft June 20, 2024 16:21
@Dieterbe Dieterbe marked this pull request as ready for review June 20, 2024 16:38
@rolandgeider
Copy link
Member

yes, ideally we would query the regular ingredient API, then we would have access to all fields and could decide what to show

@rolandgeider
Copy link
Member

Just tested this, I like it! However, I am always getting a render flex overflow error here (it seems only the first time?). I would also remove the g-per-body-kg column, that's only useful for the whole plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants