Add cli option --config-file

[bew]

It works! 🎉

I didn't find a documentation for global flags/options, is it currently missing?

I'm not fond of the duplication between wezterm/wezterm-gui/wezterm-mux-server.. But this is a larger problem I think, it shouldn't be solved in this PR.

For the implementation

• I extracted the existing config load logic to a function that takes a Path, and make it used when the flag is given.

• I changed the signature of reload (to avoid having reload() and reload_from_path(path) functions), to take a ConfigFileSelection (not sure about the naming), to choose between searching the config file or using a given one.

[wez]

Thanks for taking a crack at this! This is something that I'd use, so I definitely appreciate it!

I think this could be a smaller PR with fewer changes if you follow my suggestion of adding a global to remember the config file path.

[bew]

Thanks for the review! the code is indeed simpler now 😃

I don't know how you prefer to do code reviews, so I didn't marked your comments as resolved, so you can see my answers and mark then as resolved if it is ok for you.

[bew]

Replying to #459 (comment)

I would expect it to fail to load (and fallback to default config?) if the given file is unreadable, no?

Good catch. I think this a good place to introduce a little enum:

enum Item {
   Required(PathBuf),
   Optional(PathBuf),
}

It should be done now! tested locally, it works great!

I didn't it implemented with the enum you suggested though, I found it was quite hard to use in the for loop over paths items.
I'm not fond of the naming of PathPossiblity but don't know what to name it to.. (Item feels way too generic, or PathItem ? but it's weird, looks like a path component.. anyway..)

I hope you like it 😃

[wez]

Thanks!

[bew]

Thanks!

Youhou, thank you 😊