Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file #1

Closed
dricholm opened this issue Jul 24, 2020 · 3 comments · Fixed by #2
Closed

Config file #1

dricholm opened this issue Jul 24, 2020 · 3 comments · Fixed by #2
Labels
enhancement New feature or request

Comments

@dricholm
Copy link

Hello @westracer,

Thanks for this package! So far it works great for me.

Currently I am using it as a dev dependency in a project, where I have the svg files in the assets folder and added the generated font and dart class to .gitignore. So it works in a similar way as build_runner generated files.
But to generate the desired output I always have to specify all the arguments and options in the command, e.g. flutter pub run fontify assets/svg/ fonts/app_icons.otf --output-class-file=lib/presentation/utils/app_icons.dart -r -c AppIcons.
Right now I have the command added to README.md, but it would be a lot easier if a config file could be read for this. Something like in flutter_launcher_icons. I would prefer a separate config file, but maybe it could also be placed inside pubspec.yaml or handling both options would be even better.

What do you think of this?

@westracer
Copy link
Owner

Hello @dricholm. Thank you for the feedback, I really appreciate it.

I like the idea of reading config parameters from pubspec.yaml by default and allowing to specify other config file using cli option (like in flutter_launcher_icons). Probably, I will implement it in the next release.

@westracer westracer added the enhancement New feature or request label Jul 25, 2020
@westracer westracer mentioned this issue Aug 3, 2020
@westracer
Copy link
Owner

I've released 0.0.2 version that allows using config file and added an example usage in readme. I'll be glad to hear any feedback.

@dricholm
Copy link
Author

dricholm commented Aug 3, 2020

I just tried it out using the separate config file method, works perfect.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants