Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imprv: Dark theme support for emoji mart #8936

Merged

Conversation

reiji-h
Copy link
Contributor

@reiji-h reiji-h commented Jul 2, 2024

Summary

  • GROWI がダークモードの際、emoji mart もダークモードになるように変更

Task

Note

  • 以前使っていた emoji-mart は事情により公式のものではなかったようなので、公式のものに変更しました。
  • i18n 周りは、もともと機能していなかったので削除しました。以下のタスクが終了次第、対応可能です。

Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: 7d8d94a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

reg-suit bot commented Jul 2, 2024

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴
⚪⚪

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

"5": "Medium-Dark Skin Tone",
"6": "Dark Skin Tone"
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i18n 周りは、もともと機能していなかったので削除しました。以下のタスクが終了次第、対応可能です。

今後対応予定なのであれば削除する必要はないのでは?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emoji-mart/data 自体にすでに i18n に対応したファイルが存在するため、今後の i18n 対応でも public/static/locales/.../translation.json は使うことがないと判断し削除しました。

@yuki-takei yuki-takei merged commit f512b7c into master Jul 3, 2024
25 of 27 checks passed
@yuki-takei yuki-takei deleted the imprv/142615-148862-support-dark-theme-of-emoji-mart branch July 3, 2024 11:48
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants