Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed distracting borders on the changed parts in the diff editor #219

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

blieusong
Copy link
Contributor

@blieusong blieusong commented Feb 5, 2023

In the diff editor, the borders around the lines -and parts of lines- added or removed can be a bit overwhelming.

I propose to remove them, and think the result is much cleaner, which improves the diff editor experience overall.

Comparison 1

Before

Capture d’écran 2023-02-05 à 17 15 13

After

(note that the lines with borders seen here are where the cursor is positioned)
Capture d’écran 2023-02-05 à 17 17 47

Comparison 2

Before

Capture d’écran 2023-02-05 à 17 16 20

After

(note that the lines with borders seen here are where the cursor is positioned)
Capture d’écran 2023-02-05 à 17 18 50

@wesbos
Copy link
Owner

wesbos commented Feb 5, 2023

Ohh yes! I like this. Will review tomorrow and merge

@wesbos wesbos merged commit f69fdf4 into wesbos:master Feb 6, 2023
@wesbos
Copy link
Owner

wesbos commented Feb 6, 2023

Published 2.4.0 - thanks for such a clear fix and PR - makes my life easy

@blieusong
Copy link
Contributor Author

Thank you for the great theme.

@blieusong blieusong deleted the remove-borders-diff-colors branch February 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants