Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect styles #108

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Fix incorrect styles #108

merged 1 commit into from
Feb 13, 2017

Conversation

apopitich
Copy link
Contributor

@apopitich apopitich commented Feb 8, 2017

Should be 'transform: rotate()', but it will not look like in the video

@wesbos
Copy link
Owner

wesbos commented Feb 8, 2017

Ah yes - I was using the new rotate() syntax that isn't super well supported yet.

Can you take the .idea commit out of this?

@apopitich
Copy link
Contributor Author

Done

@apopitich
Copy link
Contributor Author

Can I add .idea to .gitignore in other commit?

@wesbos
Copy link
Owner

wesbos commented Feb 13, 2017

This doesn't add in the transform now

@apopitich
Copy link
Contributor Author

I don't know what else need I do =) I took out '.idea' commit of this pull request. Now at this PR one commit left, in which i have removed incorrect styles.

@wesbos
Copy link
Owner

wesbos commented Feb 13, 2017

You'll need to add in the correct styles - otherwise you will break this demo.

rotate(20deg)transform: rotate(20deg)

@apopitich
Copy link
Contributor Author

Oh! I wanted to do this way at the very beginning, but i thought it will not be like on the video. =)
I fixed it. And I removed .photo { float} because .strip {padding-top} hadn't worked. And I hide .strip if it's empty.

@wesbos
Copy link
Owner

wesbos commented Feb 13, 2017

sorry - can you please just replace the new rotate with the working transform? I don't care to switch anything else. I hate to be a pain, but I get so much email when things change and I can't deal with it all :)

@apopitich
Copy link
Contributor Author

Done =)

@wesbos
Copy link
Owner

wesbos commented Feb 13, 2017

thanks!

@wesbos wesbos merged commit 66ed54e into wesbos:master Feb 13, 2017
@apopitich apopitich deleted the fix-incorrect-styles branch February 13, 2017 19:24
EmmDguez pushed a commit to EmmDguez/JavaScript30 that referenced this pull request Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants