Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templates.d/99-generic/runtime-cleanup: Do not purge sound packages #1364

Closed
wants to merge 1 commit into from

Conversation

Conan-Kudo
Copy link
Contributor

@Conan-Kudo Conan-Kudo commented Jan 17, 2024

Filtering out these packages causes the build to fail when porting
Anaconda to Wayland for the boot.iso.

This is needed for rhinstaller/anaconda#5498.

@coveralls
Copy link

coveralls commented Jan 17, 2024

Pull Request Test Coverage Report for Build 7573392068

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.472%

Totals Coverage Status
Change from base Build 7277687214: 0.0%
Covered Lines: 1616
Relevant Lines: 3504

💛 - Coveralls

These cause the build to fail when adding Weston to the boot.iso.
@Conan-Kudo Conan-Kudo marked this pull request as ready for review January 18, 2024 17:23
@bcl
Copy link
Contributor

bcl commented Feb 6, 2024

Closing since this doesn't fit with what Anaconda is doing.

@Conan-Kudo
Copy link
Contributor Author

@bcl Can you please reopen and review this again, it's needed for @jexposit's work on rhinstaller/anaconda#5498.

@jexposit
Copy link

jexposit commented Mar 5, 2024

Thanks for the ping Neal. I'm going to CC @M4rtinK as he is the one doing the GNOME Remote Desktop work and he'll be able to add more details if required.

@Conan-Kudo
Copy link
Contributor Author

The PR isn't updating with the refreshed commit message, presumably because it's closed... I'll just open a new one instead. This is behaving too oddly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants