Make the plugin work on servers/wsl/headless mode #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update save-as.sh, according to https://plantuml.com/faq#239d64f675c3e515 to enable the plugin on servers/the wsl.
Update similarly to save-as according to https://plantuml.com/faq#239d64f675c3e515 in order to make the plugin work on servers/the wsl.
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally plantuml requires an X11 server. This is not necessary for this plugin and prevents it to work on wsl or server, even if the wsl can open a browser on the host and the server could save the image somewhere. Therefore I've added the headless mode flag to the plantuml call.