Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated plantuml 1.2017.15 to 1.2019.13 #20

Merged
merged 2 commits into from
Dec 23, 2019
Merged

Updated plantuml 1.2017.15 to 1.2019.13 #20

merged 2 commits into from
Dec 23, 2019

Conversation

ubmarco
Copy link
Contributor

@ubmarco ubmarco commented Dec 17, 2019

The version used does not yet support the stdlib.

@weirongxu
Copy link
Owner

weirongxu commented Dec 18, 2019

Upgrade plantuml.jar will make the repository bigger and bigger, Maybe we should consider letting users use local plantuml.jar?

@ubmarco
Copy link
Contributor Author

ubmarco commented Dec 18, 2019

I agree. What about a hybrid approach?

  1. I generally like the idea of plantuml-previewer.vim bringing its own version of plantuml.jar because user can work with it out of the box. However in this case I would find it reasonable to update plantuml.jar let's say every year.
  2. Introduce a vimrc option to pass a custom plantuml.jar path for users that need a more up-to-date version.

@ubmarco
Copy link
Contributor Author

ubmarco commented Dec 18, 2019

There might also be 2 more (less preferable) options:

  1. a feature to auto-update the own plantuml.jar once an update is detected; this would however involve starting an HTTP(S) connection which can easily fail due to various reasons
  2. pull in plantuml.jar from another repo using Git submodules; however I am not sure if all plugin managers know how to correctly deal with submodules.

@weirongxu
Copy link
Owner

OK, I will check this jar file, There are already has a variable g:plantuml_previewer#plantuml_jar_path to configure local plantuml.jar path

@weirongxu
Copy link
Owner

I see that you are using version 1.2019.12, Why not update directly to 1.2019.13?

@ubmarco
Copy link
Contributor Author

ubmarco commented Dec 18, 2019

I'm using Arch and 1.2019.12 is the current version (https://www.archlinux.org/packages/community/any/plantuml/). But we can also go to 1.2019.13. Shall I update the PR?

@ubmarco ubmarco changed the title Updated plantuml 1.2017.15 to 1.2019.12 Updated plantuml 1.2017.15 to 1.2019.13 Dec 18, 2019
@ubmarco
Copy link
Contributor Author

ubmarco commented Dec 18, 2019

I built the plantuml.jar 1.2019.13 locally and force-pushed to my fork, so there's only 1 commit to merge.

~/Downloads/plantuml-1.2019.13 $ java -jar plantuml.jar -version
PlantUML version 1.2019.13 (Tue Dec 10 18:18:29 CET 2019)
(GPL source distribution)
Java Runtime: OpenJDK Runtime Environment
JVM: OpenJDK 64-Bit Server VM
Java Version: 13.0.1+9
Operating System: Linux
Default Encoding: UTF-8
Language: en
Country: US
Machine: tux01
PLANTUML_LIMIT_SIZE: 4096
Processors: 8
Max Memory: 4,139,778,048
Total Memory: 260,046,848
Free Memory: 254,817,648
Used Memory: 5,229,200
Thread Active Count: 1

The environment variable GRAPHVIZ_DOT has not been set
Dot executable is /usr/sbin/dot
Dot version: dot - graphviz version 2.42.3 (0)
Installation seems OK. File generation OK

@weirongxu weirongxu merged commit 831703d into weirongxu:master Dec 23, 2019
@weirongxu
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants