-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIGHT/CTR mode self test failures #1234
Comments
noloader
added a commit
that referenced
this issue
Sep 29, 2023
Cleared at Commit 76fb12688b63. |
noloader
added a commit
that referenced
this issue
Sep 29, 2023
It turns out we went down a rabbit hole when we added the volatile cast gyrations in an attempt to change the compiler behavior. We are seeing the same failures from AES, Rabbit, HIGHT, HC-128 and HC-256 with and without the gyrations. We were able to work out the problems with Rabbit, HIGHT, HC-128 and HC-256. See GH #1231 and GH #1234. We are also not able to successfully cut-in Cryptogams AES on ARMv7, so it is now disabled. See GH #1236. Since the volatile casts were not a solution, we are backing it out along with associated comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rabbit, RabbitWithIV, HC128 and HC256 were producing incorrect results when
inString == outString
as reported in GH #1231. We added self tests to detect the failures, and cleared the failures.The new tests also revealed HIGHT/CTR mode also has problems.
This bug will track HIGHT/CTR.
The text was updated successfully, but these errors were encountered: