Merge pull request iovisor#452 from yadutaf/jt-solisten

solisten: clean endian conversion hack
weibang6liu · Mar 30, 2016 · ff9f231 · ff9f231
2 parents 6c08dcb + bf33014
commit ff9f231
Showing 1 changed file with 3 additions and 15 deletions.
diff --git a/tools/solisten.py b/tools/solisten.py
@@ -51,18 +51,6 @@
 #include <net/net_namespace.h>
 #include <bcc/proto.h>
 
-// Endian conversion. We can't use kernel version here as it uses inline
-// assembly, neither libc version as we can't import it here. Adapted from both.
-#if defined(__LITTLE_ENDIAN)
-#define bcc_be32_to_cpu(x) ((u32)(__builtin_bswap32)((x)))
-#define bcc_be64_to_cpu(x) ((u64)(__builtin_bswap64)((x)))
-#elif defined(__BIG_ENDIAN)
-#define bcc_be32_to_cpu(x) (x)
-#define bcc_be64_to_cpu(x) (x)
-#else
-#error Host endianness not defined
-#endif
-
 // Common structure for UDP/TCP IPv4/IPv6
 struct listen_evt_t {
  u64 ts_us;
@@ -117,11 +105,11 @@
  // Get IP
  if (family == AF_INET) {
  bpf_probe_read(evt.laddr, sizeof(u32), &(inet->inet_rcv_saddr));
- evt.laddr[0] = bcc_be32_to_cpu(evt.laddr[0]);
+ evt.laddr[0] = be32_to_cpu(evt.laddr[0]);
  } else if (family == AF_INET6) {
  bpf_probe_read(evt.laddr, sizeof(evt.laddr), sk->__sk_common.skc_v6_rcv_saddr.in6_u.u6_addr32);
- evt.laddr[0] = bcc_be64_to_cpu(evt.laddr[0]);
- evt.laddr[1] = bcc_be64_to_cpu(evt.laddr[1]);
+ evt.laddr[0] = be64_to_cpu(evt.laddr[0]);
+ evt.laddr[1] = be64_to_cpu(evt.laddr[1]);
  }
 
  // Send event to userland