Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to polish gliders for consistency #17

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

Scumi
Copy link
Contributor

@Scumi Scumi commented Jan 10, 2021

I've recognized a bunch of inconsistencies with most of the polish gliders, which I tried to correct. The original list looks like its based on the DMSt index list. Some of the changes should also be corrected there, but that's a different story.

Happy to discuss every changed line and ready to split-up the changes if necessary.

@moldhouse
Copy link
Member

Thank you for fixing these inconsistencies. Indeed I would need some more explanation as I am not too familiar with polish gliders. I think we should split the updates on the aircraft naming and the updates on the manufacturer naming into two separate commits. Also I have mixed feelings about updating names for 'Jantar' and 'Diana' as these are the common names they are known by in most countries.

@@ -130,7 +130,7 @@ ID,Glider,Model,Manufacturer,Competition Class,Winglets,Double Seater,FES,Engine
129,D 36,D 36,Akaflieg Darmstadt,18,,,,,108,108,108,108,108,108
130,Diamant 18,Diamant 18,FFA,18,,,,,108,108,108,108,108,108
131,Mü 26,Mü 26,Akaflieg München,18,,,,,102,102,102,102,102,102
132,SZD-39 Cobra 17m,Cobra 17m,SZD,18,,,,,100,100,100,100,100,100
132,SZD-39 Cobra 17,SZD-39 Cobra 17,PZL Bielsko,18,,,,,100,100,100,100,100,100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to Cobra look good

@@ -473,7 +473,7 @@ ID,Glider,Model,Manufacturer,Competition Class,Winglets,Double Seater,FES,Engine
472,LS 7,LS 7,Rolladen-Schneider,Standard,,,,,107,107,107,107,107,107
473,LS 7,LS 7 WL,Rolladen-Schneider,Standard,x,,,,107,107,107,107,107,107
474,LS 7,LS 7 neo,Rolladen-Schneider,Standard,,,,,107,107,107,107,107,107
475,SZD-55,SZD-55,PZL Bielsko,Standard,,,,,106,106,106,106,106,106
475,SZD-55,SZD-55,Allstar PZL Glider,Standard,,,,,106,106,106,106,106,106
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there exist PZL Bielsko, PZL Glider, Avionic and Allstar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, its unfortunately not that straightforward. There is a whole Wiki article about this. It kind of depends on what you want to show: Type Certificate (TC) holder or manufacturer.

  • Allstar PZL Glider is the current manufacturer and TC holder for some of those aircraft
  • Avionic has taken over the Diana 2 TC and manufacturing
  • Everything else is not manufactured anymore (the "old" stuff) and the TC holder changes from time to time. I suggest using PZL Bielsko for all these.

@Scumi
Copy link
Contributor Author

Scumi commented Jan 14, 2021

Also I have mixed feelings about updating names for 'Jantar' and 'Diana' as these are the common names they are known by in most countries.

Yes, I understand that. Unfortunately there are 3 Jantar Standard versions and one of them has a different fuselage, which according to your reasoning needs a separate entry. Their "real" designation (SZD-41 / SZD-48) reflect that. The club class IGC index list also has a different index for those two.
Question: Does it really matter when your search algorithm can pull up both (and the open class ones) entries when typing in "Jantar"?

The SZD-59 Acro is even weirder in the current index list. It does only exist without winglets in its Acro (13.2m) configuration, but that should for sure not have an index of 100.

@moldhouse
Copy link
Member

Yes I think you are right and we should go with the full name. I had a look at the type certificate and I think we should go with

SZD-41 Jantar Std.
SZD-48 Jantar Std. 2
SZD-48-3 Jantar Std. 3

and also add WL variants for all of them.

@moldhouse moldhouse merged commit 8fc3b8e into weglide:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants