Merge branch 'master' of github.com:wednesday-solutions/react-floki i…

…nto feat/remove-useInjectSaga

generated-files/container/HomeContainer/index.js

@@ -13,7 +13,7 @@ import { Helmet } from 'react-helmet';
 import { createStructuredSelector } from 'reselect';
 import { compose } from 'redux';
 import { injectSaga } from 'redux-injectors';
-import makeSelectHomeContainer from './selectors';
+import selectHomeContainerDomain from './selectors';
 import saga from './saga';
 
 export function HomeContainer() {
@@ -31,7 +31,7 @@ export function HomeContainer() {
 HomeContainer.propTypes = {};
 
 const mapStateToProps = createStructuredSelector({
- homeContainer: makeSelectHomeContainer(),
+ homeConatiner: selectHomeContainerDomain(),
 });
 
 function mapDispatchToProps(dispatch) {

generated-files/container/HomeContainer/selectors.js

@@ -5,14 +5,13 @@ import { initialState } from './reducer';
  * Direct selector to the homeContainer state domain
  */
 
-const selectHomeContainerDomain = state =>
- (state.homeContainer || initialState).toJS();
+export const selectHomeContainerDomain = state => state.homeContainer || initialState
 
-const makeSelectHomeContainer = () =>
- createSelector(
- selectHomeContainerDomain,
- substate => substate,
- );
+/**
+ * use createSelector if you are doing something with the returned state.
+ * https://redux.js.org/usage/deriving-data-selectors#createselector-overview
+ * e.g: const makeSelectHomeContainer = () =>
+ * createSelector(selectHomeContainerDomain, substate => get(substate, 'somevalue'))
+ */
 
-export default makeSelectHomeContainer;
-export { selectHomeContainerDomain };
+export default selectHomeContainerDomain

generators/container/index.js.hbs

@@ -24,7 +24,7 @@ import { compose } from 'redux'
 import { injectSaga } from 'redux-injectors';
 {{/if}}
 {{#if wantActionsAndReducer}}
-import makeSelect{{properCase name}} from './selectors'
+import select{{properCase name}} from './selectors'
 {{/if}}
 {{#if wantSaga}}
 import saga from './saga'
@@ -50,7 +50,7 @@ export function {{ properCase name }}() {
 
 {{#if wantActionsAndReducer}}
 const mapStateToProps = createStructuredSelector({
- {{ camelCase name }}: makeSelect{{properCase name}}(),
+ {{ camelCase name }}: select{{properCase name}}(),
 })
 {{/if}}
 

generators/container/selectors.js.hbs

@@ -5,10 +5,15 @@ import { initialState } from './reducer'
  * Direct selector to the {{ camelCase name }} state domain
  */
 
-const select{{ properCase name }}Domain = state => state.{{ camelCase name }} || initialState
+export const select{{ properCase name }}Domain = state => state.{{ camelCase name }} || initialState
 
-const makeSelect{{ properCase name }} = () =>
- createSelector(select{{ properCase name }}Domain, substate => substate)
 
-export default makeSelect{{ properCase name }}
-export { select{{ properCase name }}Domain }
+
+/**
+ * use createSelector if you are doing something with the returned state.
+ * https://redux.js.org/usage/deriving-data-selectors#createselector-overview
+ * e.g: const makeSelect{{ properCase name }} = () =>
+ * createSelector(select{{ properCase name }}Domain, substate => get(substate, 'somevalue'))
+ */
+
+export default select{{ properCase name }}Domain

package.json

@@ -1,6 +1,6 @@
 {
  "name": "react-floki",
- "version": "1.0.87",
+ "version": "1.0.90",
  "description": "A React component, container and test generation library",
  "repository": {
  "type": "git",