Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up for #89 #90

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Follow-up for #89 #90

merged 2 commits into from
Jun 27, 2023

Conversation

pastelmind
Copy link
Collaborator

This PR is a follow-up to #89. It addresses the following issues:

  • Packages that depend on the local version of @webtoon/psd correctly specify the version as *
  • Remove env-cmd, which is no longer needed for our release process.

During the latest round of dependency updates (#89), packages that
depend on the local version of @webtoon/psd were incorrectly updated to
point to @webtoon/psd@^0.3.0. This commit amends this oversight.
env-cmd was used to pass confidentials (e.g. API keys) as environment
variables to release-it. Since we run release-it directly from our dev
machines when publish packages to NPM, we do not need to pass
confidentials using env-cmd. Thus, we can safely remove env-cmd.
@pastelmind pastelmind added the type: maintenance General maintenance label Jun 27, 2023
@pastelmind pastelmind self-assigned this Jun 27, 2023
@pastelmind pastelmind merged commit d575f3d into main Jun 27, 2023
@pastelmind pastelmind deleted the chore-deps-update-cleanup branch June 27, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance General maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant