Backport AbortSignal feature from cohere.ai #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credits: - @kipply - @udameli - @wujessica - @1vn - @robertkozin cohere-ai/webrpc#1 cohere-ai/webrpc#3 cohere-ai/webrpc#20 --- AbortSignal docs: https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal --- Example: const controller = new AbortController(); const signal = controller.signal; setTimeout(() => controller.abort(), 5000); const { user } = await rpc.GetUser({ userId }, null, signal);
server.gen.ts:41:57 - error TS2304: Cannot find name 'AbortSignal' Add "DOM" to compilerOptions.lib in your tsconfig.json file.
| @@ -4,7 +4,8 @@ | |||
| "target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */, | |||
| "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */, | |||
| "lib": [ | |||
| "es2016" | |||
| "es2016", | |||
| "DOM" | |||
There was a problem hiding this comment.
This feels like the wrong solution, including dom in the server
Will npm install --save-dev @types/node fix it?
There was a problem hiding this comment.
Alexander Kolberg
Or we can merge, I think there is a couple of other TS issues in the server example (and the generator), and I can add some fixes and a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport AbortSignal feature from cohere.ai fork
Credits:
cohere-ai/webrpc#1
cohere-ai/webrpc#3
cohere-ai/webrpc#2
AbortSignal docs
https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal
Example