Support caching results on Win32-based systems

[dbehmoaras]

…ct creation

[webpro]

Thanks for your PR, @dbehmoaras! This is the central function to normalize paths to posix format. So I'm not sure whether this is the right location to fix the issue. What's the exact issue you're trying to solve here?

[dbehmoaras]

Thanks for your PR, @dbehmoaras! This is the central function to normalize paths to posix format. So I'm not sure whether this is the right location to fix the issue. What's the exact issue you're trying to solve here?

Hmm - I see your point. Maybe then it should be addressed in file that handles the caching of the results ? The issue we run into is that Knip fails to update the cache on windows systems because it resolves a posix file path when windows env expects a win32 path from node.js - see permalink below:

knip/packages/knip/src/util/file-entry-cache.ts

Line 41 in 2ad6583

this.filePath = isAbsolute(_path) ? resolve(_path, cacheId) : resolve(cwd, _path, cacheId);

Is there a separate file that handles win32 file paths ? Open to any approach

[webpro]

Alright, clear.

Maybe you can import path from 'node:path in file-entry-cache.ts and take it from there? Fix this.filePath with path.resolve, etc.

[dbehmoaras]

Ok let me try that

[webpro]

Great, I'm asking so you can directly test it works properly on Windows. If you update the PR, you will automatically get a new version that you can npm install anywhere, if that helps.

[pkg-pr-new]

Open in Stackblitz

bun add https://pkg.pr.new/knip@832

commit: 473ba49