Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False negative when re-exporting #698

Closed
neelmraman opened this issue Jun 25, 2024 · 4 comments
Closed

False negative when re-exporting #698

neelmraman opened this issue Jun 25, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@neelmraman
Copy link

Hi, thanks for fixing the first false negative case mentioned in #695.

Here is a repro for the third case mentioned in that issue, where re-exporting an unused export prevents the export from being reported as unused.
@neelmraman neelmraman added the bug Something isn't working label Jun 25, 2024
webpro added a commit that referenced this issue Jun 27, 2024
@webpro
Add test for re-export with includeEntryExports + `ignoreExportsUse…
12269cf 
…dInFile` (#698)
webpro added a commit that referenced this issue Jun 27, 2024
@webpro
Add test for re-export with includeEntryExports + `ignoreExportsUse…
e7f7d07 
…dInFile` (#698)
webpro added a commit that referenced this issue Jun 27, 2024
@webpro
Add test for re-export with includeEntryExports + `ignoreExportsUse…
c0a0f0b 
…dInFile` (#698)
@webpro
Copy link
Collaborator

webpro commented Jun 27, 2024

I think this might be resolved by another bug fix I did the other day. Could you please try again with v5.23.1?

@neelmraman
Copy link
Author

Ah I updated the devbox linked above to use v5.23.1 but am still seeing the issue

webpro added a commit that referenced this issue Jun 29, 2024
@webpro
Exclude nsExports, classMembers and nsTypes from --exports sh…
2e83446 
…ortcut (#698)
@webpro
Copy link
Collaborator

webpro commented Jun 29, 2024

I think the issue was fixed, but you've added the --export flag. That in turn triggered another bug, which should now be fixed. Happy to elaborate on it if you like :)

Thanks!

@webpro
Copy link
Collaborator

webpro commented Jun 29, 2024

Closing this with https://github.com/webpro-nl/knip/releases/tag/5.23.2

@webpro webpro closed this as completed Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webpro @neelmraman