Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bigint for the DefinePlugin plugin #10482

Merged
merged 7 commits into from
Mar 11, 2020
Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Feb 28, 2020

What kind of change does this PR introduce?

features (bigint can be regarded as a fix):

  • support BigInt for DefinePlugin
  • improve typeof for null
  • improve null comparison

Also we already fix undefined and array behavior for webpack@5, so after merge we can close #10425

What needs to be documented once your changes are merged?

Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

lib/javascript/JavascriptParser.js Outdated Show resolved Hide resolved
lib/DefinePlugin.js Outdated Show resolved Hide resolved
lib/javascript/BasicEvaluatedExpression.js Outdated Show resolved Hide resolved
@webpack-bot
Copy link
Contributor

@evilebottnawi Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@webpack-bot
Copy link
Contributor

The minimum test ratio has been reached. Thanks!

@alexander-akait
Copy link
Member Author

Done

lib/DefinePlugin.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@alexander-akait
Copy link
Member Author

/cc @sokra conflicts fixed, will be great to merge it so that I can continue to improve and avoid conflicts

@sokra sokra force-pushed the feat-bigint-for-DefinePlugin branch from f7e803f to 994b47f Compare March 9, 2020 09:59
@sokra sokra merged commit fcd63bc into master Mar 11, 2020
@sokra
Copy link
Member

sokra commented Mar 11, 2020

Thanks

@sokra sokra deleted the feat-bigint-for-DefinePlugin branch March 11, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefinePlugin doesn't handle arrays & undefined correctly
3 participants