Handle periods in directory names when interpolating paths

[pugnascotia]

Given:

• A filename without an extension, and
• A directory path containing a period

...the result from interpolateName is wrong. I've reworked the code and added some tests to cover this.

[jsf-clabot]

All committers have signed the CLA.

[pugnascotia]

Aw, no fair on the decreased coverage - it's because there's fewer lines of code :-(

[pugnascotia]

Maintainers - I can add tests to increase the coverage score, but that will increase the scope of these changes. What would you like me to do?

[Timer]

Hi!

We would love to see some feedback given on this issue so that it may be merged and released.
We're depending on it as part of our CRA [email protected] release, which switches to webpack@2!
@pugnascotia has been working hard to give us a whitelisted url-loader and our comprehensive e2e uncovered this bug. 🔥

Let me know if there's anything I can do to help facilitate this process, and thanks to all parties!

/cc @jhnns

[jhnns]

Thanks! That looks good. It makes sense to use path.parse() here since loaderContext.resourcePath is a native, absolute path, so node's parsing algorithm should work as expected. I don't know why @sokra preferred to parse it manually here 😬

Published as 1.0.3