Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/get options #68

Merged
merged 2 commits into from
Feb 21, 2017
Merged

Fix/get options #68

merged 2 commits into from
Feb 21, 2017

Conversation

jhnns
Copy link
Member

@jhnns jhnns commented Feb 21, 2017

Unify the handling of unexpected queries:

  1. If this.query is a string:
    • Tries to parse the query string and returns a new object
    • Throws if it's not a valid query string
  2. If this.query is object-like, it just returns this.query
  3. In any other case, it just returns null

#56

Unify the handling of unexpected queries:
1. If `this.query` is a string:
	- Tries to parse the query string and returns a new object
	- Throws if it's not a valid query string
2. If `this.query` is object-like, it just returns `this.query`
3. In any other case, it just returns `null`

#56
@jhnns jhnns merged commit d396c62 into master Feb 21, 2017
@jhnns jhnns deleted the fix/get-options branch February 21, 2017 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant