Allow function interpolation #59
Conversation
|
|
|
That looks good, thank you. Could you replace the |
|
Sure @jhnns, I have changed it as requested. |
index.js
Outdated
| @@ -249,7 +249,12 @@ exports.getHashDigest = function getHashDigest(buffer, hashType, digestType, max | |||
| }; | |||
|
|
|||
| exports.interpolateName = function interpolateName(loaderContext, name, options) { | |||
| var filename = name || "[hash].[ext]"; | |||
| var filename; | |||
| if (typeof name === 'function') { | |||
There was a problem hiding this comment.
Sorry for nitpicking, but please use double quotes 😁 (you can push force on this branch)
There was a problem hiding this comment.
@jhnns I have used triple equations, because that was used everywhere else in the script, but I have changed as requested.
|
Sorry, that's a misunderstanding. Triple-equality |
|
I'll change that with my next commit. Anyway, thx 👍 |
|
@jhnns haha sorry, I totally misinterpreted :) |
|
Shipped with |
Currently generating names is quite restrictive - it only allows a fix number of opportunities.
I propose letting the
nameparameter to be a function, so developers can return whatever name they want based on the resource path with their own logic.As a real-life example, I would like assets in
node_modulesto be in a subfolder ofimagesnamed after the package, while assets from other paths should be placed in the root ofimages. Currently I haven't found a way to achieve this.There should be no breaking change to existing configurations.