Fix compatibility with webpack 5 #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
+ Coverage 88.93% 89.40% +0.46%
==========================================
Files 11 6 -5
Lines 696 755 +59
Branches 194 227 +33
==========================================
+ Hits 619 675 +56
- Misses 74 77 +3
Partials 3 3
Continue to review full report at Codecov.
|
abearxiong
reviewed
Feb 25, 2021
|
|
||
| class MiniCssExtractPlugin { | ||
| static getCssModule(webpack) { | ||
| class CssModule extends webpack.Module { |
There was a problem hiding this comment.
why i will get undefined;
"webpack": "5.15.0",
"webpack-build-notifier": "^2.1.1",
"webpack-cli": "^4.5.0",
"webpack-dev-server": "^3.11.2",
"webpack-merge": "^5.7.3"
There was a problem hiding this comment.
Please create reproducible test repo
6 tasks
|
Hi. I think this commit cause this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
use
compiler.webpackfor better compatibility with webpack v5fixes #668
Breaking Changes
No
Additional Info
No