Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webdriverio): dialog handler #13247

Merged
merged 2 commits into from
Jul 30, 2024
Merged

feat(webdriverio): dialog handler #13247

merged 2 commits into from
Jul 30, 2024

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch introduces a new WebdriverIO primitive for handling dialogs. Users can listen on dialogs via browser.on('dialog') and handle them manually or if not, they will be handled/dismissed automatically.

I updated the docs:
Screenshot_2024-07-29_at_10 16 35_PM

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann merged commit 1757219 into main Jul 30, 2024
44 checks passed
@christian-bromann christian-bromann deleted the cb/dialog branch July 30, 2024 14:45
@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Aug 15, 2024
@christian-bromann christian-bromann added this to the v9 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant