Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip 0x prefixed private key #31

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Strip 0x prefixed private key #31

merged 2 commits into from
Nov 15, 2020

Conversation

sc0Vu
Copy link
Member

@sc0Vu sc0Vu commented Nov 15, 2020

Fix #27 #28

Maybe #30?

It seems 0x prefixed private key break the ec sign.

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #31 (534fa0d) into master (5b14653) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
+ Coverage     88.80%   89.05%   +0.24%     
- Complexity       64       65       +1     
============================================
  Files             1        1              
  Lines           134      137       +3     
============================================
+ Hits            119      122       +3     
  Misses           15       15              
Impacted Files Coverage Δ Complexity Δ
src/Transaction.php 89.05% <100.00%> (+0.24%) 65.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b14653...534fa0d. Read the comment docs.

@sc0Vu sc0Vu merged commit be5a106 into web3p:master Nov 15, 2020
@sc0Vu sc0Vu deleted the strip-priv-key branch November 15, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sign function does not work correctly
1 participant