Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #15 #16

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Fix #15 #16

merged 1 commit into from
Jun 18, 2018

Conversation

sc0Vu
Copy link
Member

@sc0Vu sc0Vu commented Jun 18, 2018

Change

  • Change nonce, gas, gasLimit, gasPrice allowZero to false.
  • Change check zero statement.
  • Add test for issue The 0x00 nonce error #15.

Change
* Change nonce, gas, gasLimit, gasPrice allowZero to false.
* Change check zero statement.
* Add test for issue web3p#15.
@codecov-io
Copy link

codecov-io commented Jun 18, 2018

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     86.56%   86.56%           
+ Complexity       67       64    -3     
=========================================
  Files             1        1           
  Lines           134      134           
=========================================
  Hits            116      116           
  Misses           18       18
Impacted Files Coverage Δ Complexity Δ
src/Transaction.php 86.56% <100%> (ø) 64 <0> (-3) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b5340c...0f56c03. Read the comment docs.

@sc0Vu sc0Vu merged commit b7714ce into web3p:master Jun 18, 2018
@sc0Vu sc0Vu deleted the fix-15 branch June 18, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants