Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12 #13

Merged
merged 3 commits into from
Jun 13, 2018
Merged

Fix #12 #13

merged 3 commits into from
Jun 13, 2018

Conversation

sc0Vu
Copy link
Member

@sc0Vu sc0Vu commented Jun 13, 2018

Change
Add attribute map
Check attribute when set the value

For more detail, see #12

@codecov-io
Copy link

Codecov Report

Merging #13 into master will decrease coverage by 0.79%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #13     +/-   ##
===========================================
- Coverage     86.61%   85.82%   -0.8%     
- Complexity       56       67     +11     
===========================================
  Files             1        1             
  Lines           127      134      +7     
===========================================
+ Hits            110      115      +5     
- Misses           17       19      +2
Impacted Files Coverage Δ Complexity Δ
src/Transaction.php 85.82% <75%> (-0.8%) 67 <0> (+11)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1d214...ebeafc8. Read the comment docs.

@sc0Vu sc0Vu merged commit c1ff45c into web3p:master Jun 13, 2018
@sc0Vu sc0Vu deleted the fix-12 branch June 13, 2018 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants