failed test for value = 0

[olegabr]

This PR intensionally failing tests

I'm trying to call contract methods and get this error in return:

Failed to sendRawTransaction: RuntimeException: rlp: non-canonical integer (leading zero bytes) for *big.Int, decoding into (types.Transaction)(types.txdata).Amount

I've tryed a lot of variants with your tests code. The only one that fails is when value is zero. It is typically the case when contract methods are called.

I've used ethereumjs-tx nodejs lib to independently calculate the signed transaction hex.

[sc0Vu]

After trace this issue, found that the length and zero limit in ethereum transaction.
The value was transformed into empty buffer because of the limit, the hashed rlp encode were different.

Two different rlp encoded transaction data:

JS:
e4098504a817c800825208943535353535353535353535353535353535353535 80 80018080

PHP
e4098504a817c800825208943535353535353535353535353535353535353535 00 80018080

I think the best way to fix this is adding the two limit in library.
I'll merge this pr after finish the two limit.

Right now, you can get the correct signing data if value is empty string (0x80).
Thanks!

[codecov-io]

Codecov Report

Merging #11 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
- Coverage     86.61%   86.56%   -0.05%     
- Complexity       56       67      +11     
============================================
  Files             1        1              
  Lines           127      134       +7     
============================================
+ Hits            110      116       +6     
- Misses           17       18       +1

Impacted Files	Coverage Δ	Complexity Δ
src/Transaction.php	86.56% <0%> (-0.05%)	67% <0%> (+11%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1d214...74034ba. Read the comment docs.