Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve test snapshot issue between node 18 vs 20 & 21 #6794

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #6756

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue Feb 7, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 7, 2024

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 0 618 KB 618 KB -
View detailed bundle breakdown

Added

Asset Old size New size Diff Diff %
web3.min.js 0 601 KB 601 KB -
../lib/commonjs/index.d.ts 0 8.63 KB 8.63 KB -
../lib/commonjs/accounts.d.ts 0 3.89 KB 3.89 KB -
../lib/commonjs/types.d.ts 0 2.45 KB 2.45 KB -
../lib/commonjs/web3.d.ts 0 1.14 KB 1.14 KB -
../lib/commonjs/abi.d.ts 0 999 bytes 999 bytes -
../lib/commonjs/eth.exports.d.ts 0 280 bytes 280 bytes -
../lib/commonjs/providers.exports.d.ts 0 148 bytes 148 bytes -
../lib/commonjs/version.d.ts 0 60 bytes 60 bytes -

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

Copy link

github-actions bot commented Feb 7, 2024

Benchmark

Benchmark suite Current: 7cdd095 Previous: 6c075db Ratio
processingTx 9592 ops/sec (±3.98%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 39554 ops/sec (±8.25%) 39129 ops/sec (±7.62%) 0.99
processingContractMethodSend 19249 ops/sec (±6.38%) 19443 ops/sec (±5.19%) 1.01
processingContractMethodCall 38822 ops/sec (±5.19%) 38971 ops/sec (±6.34%) 1.00
abiEncode 46078 ops/sec (±6.41%) 44252 ops/sec (±6.92%) 0.96
abiDecode 31769 ops/sec (±7.08%) 30419 ops/sec (±8.89%) 0.96
sign 1621 ops/sec (±3.48%) 1656 ops/sec (±4.08%) 1.02
verify 377 ops/sec (±0.64%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@Muhammad-Altabba
Copy link
Contributor Author

Muhammad-Altabba commented Feb 7, 2024

The test cases are still failing due to other issues which came after merging: #6778

@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review February 7, 2024 12:00
@jdevcs
Copy link
Contributor

jdevcs commented Feb 9, 2024

There are list of tests not passing

@luu-alex luu-alex mentioned this pull request Feb 9, 2024
17 tasks
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #6794 (7cdd095) into 4.x (4358140) will increase coverage by 4.65%.
Report is 172 commits behind head on 4.x.
The diff coverage is 95.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6794      +/-   ##
==========================================
+ Coverage   87.37%   92.03%   +4.65%     
==========================================
  Files         197      214      +17     
  Lines        7548     8171     +623     
  Branches     2059     2200     +141     
==========================================
+ Hits         6595     7520     +925     
+ Misses        953      651     -302     
Flag Coverage Δ
UnitTests 92.03% <95.84%> (+4.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3-core snapshot issue
4 participants